Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Conversation

RalfEggert
Copy link
Contributor

Remove the hard coded dependency to the Zend\Mvc\MvcEvent::EVENT_BOOTSTRAP constant from Zend\ModuleManager component by adding a new constant to Zend\ModuleManager\ModuleManager.

Look at #6933

@Ocramius
Copy link
Member

This can gladly land in 2.3.4 as well

@RalfEggert
Copy link
Contributor Author

Sounds great. I just wonder if the https://github.com/zendframework/zf2/blob/master/library/Zend/ModuleManager/composer.json shouldn't be amended as well?

@Ocramius
Copy link
Member

@RalfEggert yes please :-)

@RalfEggert
Copy link
Contributor Author

I'll do it tonight.

@RalfEggert
Copy link
Contributor Author

I only deleted the Zend\Mvc requirement from the require-dev section. I left it in the suggest section. I hope that is ok.

@Ocramius
Copy link
Member

@RalfEggert should probably still be in require-dev

@RalfEggert
Copy link
Contributor Author

Hmm. But it wasn't in the require section any way? So revert the composer.json change?

@Ocramius
Copy link
Member

Nope, the hard dep should go away, but the tests may still rely on the Mvc component (has to be checked, eventually)

@Ocramius Ocramius closed this in f1a6863 Dec 31, 2014
Ocramius added a commit that referenced this pull request Dec 31, 2014
@Ocramius
Copy link
Member

Merged after cherry-picking onto a new branch from master, thanks @RalfEggert!

master: f1a6863
develop: 935841c

gianarb pushed a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants