This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Applications packaged as not capable of loading modules contained within the archive #7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requiring a test case... |
| $file = new SplFileInfo($dirPath . '/Module.php'); | ||
| if ($file->isReadable() && $file->isFile()) { | ||
| $modulePath = $dirPath . '/Module.php'; | ||
| if (substr($modulePath, 0, 7) == 'phar://') { |
There was a problem hiding this comment.
please use strict comparision
|
@Ocramius : haz test |
|
@basz thanks, looks much better! |
|
@Ocramius out of curiosity, if this lands, will it land in master when reviews are done or are you waiting with merging moments before 2.3.5 is released? |
|
@basz I'm waiting for a legendary magical beast called "free time" ;-) I merge when I have a bit of dedicated time to do so. Yes, merge will happen before 2.3.5/2.4 |
|
hook your magic method __sleep to __clone and time is multiplied. thanks |
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…g-broken-in-module-manager' Close zendframework/zendframework#7151 Close zendframework/zendframework#7148
gianarb
pushed a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…g-broken-in-module-manager' into develop Close zendframework/zendframework#7151 Close zendframework/zendframework#7148 Forward port zendframework/zendframework#7151 Forward port zendframework/zendframework#7148
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ModuleAutoloader fails to load modules when the modules are part of the phar that contains the application.
A realpath check on phar://path/to/phar.phar/modules/Application/Module.php will return false. There no such thing as a realpath on the real filesystem for these kind of files.
This fix uses the Phar::current(true) method to find out the correct basepath of the application. Then regular loadModuleFromDir is after minor adjustment capable to load the module.php 'fromDir'.
Note existing tests still pass, but I did not write a new one for this addition. I wouldn't know how to do that for such a case.
original #7148