-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Fixes #4936 #7152
Fixes #4936 #7152
Conversation
Requires test case |
@Ocramius I've added. Dunno how it write it better. |
@kusmierz the test should be related to |
Indeed, you've right. I hope there is no more usages of "key()" function on PriorityList in code (I've checked it quickly). Is it correct now? |
@@ -11,6 +11,7 @@ | |||
|
|||
use Zend\Mvc\Router\PriorityList; | |||
use PHPUnit_Framework_TestCase as TestCase; | |||
use Zend\Stdlib\ArrayUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should be on ChainTest
, as that's where the code changes are.
I've finally found time to write it. @Ocramius could you check it if it's ok now? Thanks in advance. Without my fix, the new test will fail on:
|
@Ocramius, have you added this to v2.3.5? |
@kusmierz no, as you can see it's scheduled for 2.4.0 |
…n better tests
It will fix #4936 issue.