This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Exception message in Zend\Stdlib\AbstractOptions should use the actual used setter #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-P
force-pushed
the
hotfix/abstractoptions-exception-message
branch
from
71b08a7 to
3f4c7ad
Compare
|
Was thinking about changing the value of |
|
I know I'm pedantic here, but can haz test? |
|
I added a test for the exception message, but I may hope nobody uses the exception message itself as a way to test which exception is thrown. |
Yeah, it's not about that, it's mainly about the usual "cast to string" and such errors ;-) |
Ocramius
added a commit
that referenced
this pull request
Feb 2, 2015
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…s-missing-setter-error-message-fix' Close zendframework/zendframework#7157
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…pectations to the rebased branch contents
gianarb
pushed a commit
to zendframework/zend-stdlib
that referenced
this pull request
May 15, 2015
…s-missing-setter-error-message-fix' into develop Close zendframework/zendframework#7157 Forward port zendframework/zendframework#7157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current exception message uses some fabricated setter which is not even used in the actual test in
Zend\Stdlib\AbstractOptionsline 103.This PR changes the exception message and makes it use the actual used setter and thus creates a more accurate message. See: #7155 (comment)