Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

fix some of the documentation errors #7194

Merged
merged 1 commit into from
Feb 25, 2015
Merged

fix some of the documentation errors #7194

merged 1 commit into from
Feb 25, 2015

Conversation

jaapio
Copy link
Contributor

@jaapio jaapio commented Feb 8, 2015

No description provided.

public function toString()
{
return parent::__toString();
}

/**
* @return string
*/
public function __toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this method only calls parent::__toString(), it has no use and can be removed.

@jaapio
Copy link
Contributor Author

jaapio commented Feb 9, 2015

@Martin-P tnx for your comments. I 'm working in an other branch to clean this up. There are several methods in the zf-code component that where not covered by tests and methods like these tostring that are useless. I didn't want to mix those changes, so this one only contains docblock changes.

@jaapio
Copy link
Contributor Author

jaapio commented Feb 10, 2015

The to string methods are possibly added for the same reason why this was done in the FunctionReflection class There are no tests for this method and I could reproduce it by adding a test?

@Martin-P
Copy link
Contributor

Required due to bug in php

@ralphschindler You wrote this comment. Can you elaborate on this and provide a link to the bug you were referring to?

@weierophinney
Copy link
Member

@Martin-P IIRC, we have to override the __toString() method and have it delegate to the parent, because if we do not, string serialization will not work; that's the bug referred to, and, also IIRC, php.net decided it was not a bug, but a "feature."

@weierophinney weierophinney added this to the 2.4.0 milestone Feb 19, 2015
@weierophinney weierophinney merged commit cd00f91 into zendframework:develop Feb 25, 2015
weierophinney added a commit that referenced this pull request Feb 25, 2015
fix some of the documentation errors
weierophinney added a commit that referenced this pull request Feb 25, 2015
weierophinney added a commit to zendframework/zend-barcode that referenced this pull request May 14, 2015
…ock_fixes

fix some of the documentation errors
weierophinney added a commit to zendframework/zend-barcode that referenced this pull request May 14, 2015
weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
…ock_fixes

fix some of the documentation errors
weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants