This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
DateStep time for moscow fixes #7261 #7262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell, the failing build now has nothing to do with my commits. |
| * | ||
| * @return bool | ||
| */ | ||
| private function isSpaningSpecialCase($baseDate, $valueDate) |
|
@Victory please address the feedback left by both myself and @froschdesign , and I'll review again for merge. |
|
@weierophinney - I have fixed the typo and used The discussion with @froschdesign is on going. Thanks! |
|
@weierophinney and @froschdesign i have just change my approach quite a bit to not have any checks for specific time zones. I think this is much better approach then what i tired before. |
|
@Victory |
|
Ok @weierophinney I think I have addressed all concerns for this pull request. Let me know if there is anything else you would like updated. |
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
DateStep time for moscow fixes #7261
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…StepTime-for-moscow DateStep time for moscow fixes zendframework/zendframework#7261
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a test and fix for the "Wintertime" bug for DateStepValidator in Moscow.