This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Adds preserve defined order as a factory option #7276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,17 +18,29 @@ class FormAnnotationBuilderFactoryTest extends TestCase | |||
| public function testCreateService() | |||
| { | |||
| $mockElementManager = $this->getMock('Zend\Form\FormElementManager'); | |||
| $mockValidatorManager = $this->getMock('Zend\Validator\ValidatorPluginManager'); | |||
| $mockFilterManager = $this->getMock('Zend\Filter\FilterPluginManager'); | |||
There was a problem hiding this comment.
Why are you removing these?
There was a problem hiding this comment.
Granted, tests pass without them, so likely they aren't needed.
There was a problem hiding this comment.
They were required by a previous implementation of the factory; I improved it but hadn't removed them from the test
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
…er-factory Adds preserve defined order as a factory option
weierophinney
added a commit
that referenced
this pull request
Mar 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.