This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Code\Generator\ClassGenerator can not generate final classes #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
Zend\Code\Generator\ClassGenerator can not generate final classes
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend\Code\Generator\ClassGenerator accepts a final flag, but does not generate code for final classes.
I've added a test and fix, I restricted the implementation to declaring the class either abstract or final, not both. (http://phpsadness.com/sad/41) Preference was given to abstract classes so as to not break any existing code that set both abstract and final flags.