This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed form collections with nested fieldsets that implements InputfilterProviderInterface #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terProviderInterface
| $inputFilter->getInputFilter()->add($input, $filterName); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think it can be copied into separate private method to reduce repetitive addition block code
There was a problem hiding this comment.
You're right. I added addInputsToCollectionInputFilter.
| @@ -274,59 +274,6 @@ public function testReuseMatchedParametersWithSegmentController() | |||
| $this->assertEquals(303, $prgResultRoute->getStatusCode()); | |||
| } | |||
|
|
|||
| public function testFieldsetAmountInFormEqualsFieldsetsInInputFilter() | |||
There was a problem hiding this comment.
I deleted this test, because now a CollectionInputFilter is used for collections and there is no need for checking the same amount of fieldsets and InputFilters. Please correct me, if I am wrong.
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
Fixed form collections with nested fieldsets that implements InputfilterProviderInterface
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for the usage of collections and the
InputFilterProviderInterface.The problem was: If you're using
getInputFilterSpecification()for your fieldsets and embed them in a collection, the input filters were never added to the form, resulting in errors when usingsetValidationGroup()or the inability to bind data to nested fieldsets.The fix also ensures that infinite nested collections with
InputFilterProviderInterface-fieldsets are working correctly.