This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
zf7428 fixed issue with inconsistent getTrait() behaviour #7428 #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stepashka69
commented
Apr 7, 2015
stepashka69
commented
- Made getTraits() to behave the same was a parent method - return null only in case of error and empty array otherwise
- Added phpdoc comment
- Added tests for getTraits()
| public function getTraits() | ||
| { | ||
| $vals = array(); | ||
| $traits = parent::getTraits(); | ||
| if (! $traits) { | ||
| return; | ||
| if ($traits === null) { |
There was a problem hiding this comment.
$traits === null is not possible here, because ReflectionClass:getTraits() returns array or null in case of an error (see manual). if (! $traits) { is correct here.
There was a problem hiding this comment.
if $traits is empty array then if (! $traits) is true and the return of getTraits() is null. It is incorrect behaviour which broke a lot of unittests in my projects.
|
👍 Thanks for catching that. |
| $this->dummy = boolval($dummy); | ||
| return $this; | ||
| } | ||
| } |
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
zf7428 fixed issue with inconsistent getTrait() behaviour #7428
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
- Use `assertInternalType()` and `assertCount()`
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.