This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[#7396] Functionality only works in PHP >= 5.6 #7483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a RuntimeException when the method is invoked in versions less than 5.6, and skip unit tests in those situations as well. Also fixes several long lines.
| @@ -86,9 +86,14 @@ public function testGetConnectionStringEncodeSpecialSymbol() | |||
| */ | |||
| public function testSetConnectionTypeException() | |||
| { | |||
| if (version_compare(PHP_VERSION, '5.6', 'lt')) { | |||
There was a problem hiding this comment.
there are if (PHP_VERSION_ID) check used instead of version_compare in other source, for example : https://github.com/zendframework/zf2/blob/master/library/Zend/Stdlib/JsonSerializable.php#L12.
what we will be using for consistencies ?
|
#7482 provides a fix too but from a "feature exists" approach |
|
Merged #7482 instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7396 introduced code that only works in 5.6; this patch does the following:
setType()method is invoked inversions less than 5.6.
This patch also fixes several long lines, flagged by phpcs when I was editing.