From c2ae579f0b1be8e28509c681cfac14e27eb09fc4 Mon Sep 17 00:00:00 2001 From: Robert Lubos Date: Mon, 30 Nov 2020 17:29:33 +0100 Subject: [PATCH] tests: openthread: Fix build warnings Fix build warnings from llvm/clang build. Fixes #30328 Signed-off-by: Robert Lubos --- tests/subsys/openthread/radio_test.c | 49 +++++++++++++++++++--------- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/tests/subsys/openthread/radio_test.c b/tests/subsys/openthread/radio_test.c index 08b361992ab7..38e8a3f7e259 100644 --- a/tests/subsys/openthread/radio_test.c +++ b/tests/subsys/openthread/radio_test.c @@ -423,13 +423,15 @@ static void test_tx_test(void) zassert_not_null(frm, "Transmit buffer is null."); - otPlatRadioSetTransmitPower(ot, power); + zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE, + "Failed to set TX power."); ztest_returns_value(set_channel_mock, 0); ztest_expect_value(set_channel_mock, channel, chan); ztest_expect_value(set_txpower_mock, dbm, power); ztest_expect_value(start_mock, dev, &radio); - otPlatRadioReceive(ot, chan); + zassert_equal(otPlatRadioReceive(ot, chan), OT_ERROR_NONE, + "Failed to receive."); /* ACKed frame */ frm->mChannel = chan2; @@ -490,11 +492,15 @@ static void test_tx_power_test(void) { int8_t out_power = 0; - otPlatRadioSetTransmitPower(ot, -3); - otPlatRadioGetTransmitPower(ot, &out_power); + zassert_equal(otPlatRadioSetTransmitPower(ot, -3), OT_ERROR_NONE, + "Failed to set TX power."); + zassert_equal(otPlatRadioGetTransmitPower(ot, &out_power), + OT_ERROR_NONE, "Failed to obtain TX power."); zassert_equal(out_power, -3, "Got different power than set."); - otPlatRadioSetTransmitPower(ot, -6); - otPlatRadioGetTransmitPower(ot, &out_power); + zassert_equal(otPlatRadioSetTransmitPower(ot, -6), OT_ERROR_NONE, + "Failed to set TX power."); + zassert_equal(otPlatRadioGetTransmitPower(ot, &out_power), + OT_ERROR_NONE, "Failed to obtain TX power."); zassert_equal(out_power, -6, "Second call to otPlatRadioSetTransmitPower failed."); } @@ -570,24 +576,29 @@ static void test_source_match_test(void) sys_put_le16(12345, ext_addr.m8); set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, false, true); - otPlatRadioAddSrcMatchShortEntry(ot, 12345); + zassert_equal(otPlatRadioAddSrcMatchShortEntry(ot, 12345), + OT_ERROR_NONE, "Failed to add short src entry."); + for (int i = 0; i < sizeof(ext_addr.m8); i++) { ext_addr.m8[i] = i; } set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, true, true); - otPlatRadioAddSrcMatchExtEntry(ot, &ext_addr); + zassert_equal(otPlatRadioAddSrcMatchExtEntry(ot, &ext_addr), + OT_ERROR_NONE, "Failed to add ext src entry."); /* Clear */ sys_put_le16(12345, ext_addr.m8); set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, false, false); - otPlatRadioClearSrcMatchShortEntry(ot, 12345); + zassert_equal(otPlatRadioClearSrcMatchShortEntry(ot, 12345), + OT_ERROR_NONE, "Failed to clear short src entry."); set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, true, false); - otPlatRadioClearSrcMatchExtEntry(ot, &ext_addr); + zassert_equal(otPlatRadioClearSrcMatchExtEntry(ot, &ext_addr), + OT_ERROR_NONE, "Failed to clear ext src entry."); set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, NULL, false, false); @@ -724,7 +735,8 @@ static void test_radio_state_test(void) const uint8_t channel = 12; const uint8_t power = 10; - otPlatRadioSetTransmitPower(ot, power); + zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE, + "Failed to set TX power."); zassert_equal(otPlatRadioDisable(ot), OT_ERROR_NONE, "Failed to disable radio."); @@ -748,7 +760,8 @@ static void test_radio_state_test(void) ztest_expect_value(set_channel_mock, channel, channel); ztest_expect_value(set_txpower_mock, dbm, power); ztest_expect_value(start_mock, dev, &radio); - otPlatRadioReceive(ot, channel); + zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE, + "Failed to receive."); zassert_equal(platformRadioChannelGet(ot), channel, "Channel number not remembered."); @@ -834,13 +847,15 @@ static void test_receive_test(void) net_pkt_set_ieee802154_lqi(packet, lqi); net_pkt_set_ieee802154_rssi(packet, rssi); - otPlatRadioSetTransmitPower(ot, power); + zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE, + "Failed to set TX power."); ztest_returns_value(set_channel_mock, 0); ztest_expect_value(set_channel_mock, channel, channel); ztest_expect_value(set_txpower_mock, dbm, power); ztest_expect_value(start_mock, dev, &radio); - otPlatRadioReceive(ot, channel); + zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE, + "Failed to receive."); /* * Not setting any expect values as nothing shall be called from @@ -873,13 +888,15 @@ static void test_net_pkt_transmit(void) /* success */ len = alloc_pkt(&packet, 2, 'a'); buf = packet->buffer; - otPlatRadioSetTransmitPower(ot, power); + zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE, + "Failed to set TX power."); ztest_returns_value(set_channel_mock, 0); ztest_expect_value(set_channel_mock, channel, channel); ztest_expect_value(set_txpower_mock, dbm, power); ztest_expect_value(start_mock, dev, &radio); - otPlatRadioReceive(ot, channel); + zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE, + "Failed to receive."); notify_new_tx_frame(packet);