Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86_64: interrupt stack overflows are not caught #21495

Closed
andrewboie opened this issue Dec 18, 2019 · 2 comments
Closed

x86_64: interrupt stack overflows are not caught #21495

andrewboie opened this issue Dec 18, 2019 · 2 comments
Assignees
Labels
area: X86_64 x86-64 Architecture (64-bit) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale

Comments

@andrewboie
Copy link
Contributor

x86_64 does not catch stack overflows that take place on the interrupt stack as expected by the CONFIG_HW_STACK_PROTECTION feature.

In detail, x86_64 uses separate interrupt stack buffers for each IRQ nesting level. None of them have guard pages configured. We need to have a guard page for every IRQ nesting level stack, or have nested IRQs take place all on the same stack with a guard region at the end (which is what most arches do).

We need a test case which proves that the scenario works, our current tests for stack overflows only test thread stacks, not interrupts or exceptions.

@andrewboie andrewboie added bug The issue is a bug, or the PR is fixing a bug area: X86_64 x86-64 Architecture (64-bit) labels Dec 18, 2019
@jhedberg jhedberg added the priority: low Low impact/importance bug label Jan 7, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Aug 13, 2020
@nashif nashif removed the Stale label Aug 26, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: X86_64 x86-64 Architecture (64-bit) bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
None yet
Development

No branches or pull requests

3 participants