Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: can: Check bus-timing values at compile-time #22333

Closed
alexanderwachter opened this issue Jan 30, 2020 · 2 comments
Closed

drivers: can: Check bus-timing values at compile-time #22333

alexanderwachter opened this issue Jan 30, 2020 · 2 comments
Assignees
@alexanderwachter
Labels
area: CAN Enhancement Changes/Updates/Additions to existing features

Comments

@alexanderwachter
Copy link
Member

Is your enhancement proposal related to a problem? Please describe.
The CAN drivers check the bus-timing parameters only at run-time with code like __ASSERT(cfg->sjw >= 1, "SJW minimum is 1");. Hence, errors are only thrown when asserts are turned on.

Describe the solution you'd like

  • Make the tests failing at compile-time.
  • Add the same chacks for every driver.
@alexanderwachter alexanderwachter added Enhancement Changes/Updates/Additions to existing features area: CAN labels Jan 30, 2020
@alexanderwachter alexanderwachter self-assigned this Jan 30, 2020
@alexanderwachter
Copy link
Member Author

Ping @karstenkoenig @henrikbrixandersen.

@alexanderwachter
Copy link
Member Author

Solved by #28345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderwachter alexanderwachter

Labels
area: CAN Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexanderwachter