[v1.14] Bluetooth: controller: Fix uninit conn context after invalid channel map

[erbr-ot]

When a connect indication contains a channel map of all zeros, the adv->conn is left NULL'ed after connect establishment is abborted and next connect attempt leads to a crash.

This was identified via the Sweyntooth test suite - executing the script re. issue 6.14 towards an Oticon target.
https://asset-group.github.io/disclosures/sweyntooth/
Zephyr v1.14 needs to be analysed.

See #27507

[carlescufi]

@erbr-ot will you create a backport PR for this, targetting the v1.14-branch?

[erbr-ot]

@carlescufi I will, in the next few days.

[erbr-ot]

Hi @carlescufi - sorry this got back-seated during our race to finish-line. Looking into this now, and have a question: I see that the guard re. lll->data_chan_hop is not present in v1.14.2, should I introduce this also in the same PR?

[carlescufi]

Hi @carlescufi - sorry this got back-seated during our race to finish-line. Looking into this now, and have a question: I see that the guard re. lll->data_chan_hop is not present in v1.14.2, should I introduce this also in the same PR?

I think this is a question for @cvinayak

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[cvinayak]

This slipped through me. Now addressed here #33760