Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Get rid of shell UART device selection in Kconfig #27677

Closed
de-nordic opened this issue Aug 19, 2020 · 3 comments
Closed

RFC: Get rid of shell UART device selection in Kconfig #27677

de-nordic opened this issue Aug 19, 2020 · 3 comments
Assignees
Labels
RFC Request For Comments: want input from the community

Comments

@de-nordic
Copy link
Collaborator

Introduction

The selection of UART device for usage with shell seems redundant when it is possible to use DTS overlay to do so.
The configuration item is UART_SHELL_ON_DEV_NAME.

Problem description

Possibility of selecting UART device via Kconfig causes additional problem as it adds additional level, to existing support for DTS overlays.
As a result it is possible to override board dts on two levels which is redundant. This may also cause problem when user decides to change UART assignment via DTS overlay, being unaware that configuration will override it.

Proposed change

Remove possibility to select UART device assigned to shell via Kconfig, by removing UART_SHELL_ON_DEV_NAME configuration
item, and rely on DTS overlays overriding the zephyr,shell-uart alias.

Dependencies

All project using the UART_SHELL_ON_DEV_NAME would need to include DTS overlay instead.

Concerns and Unresolved Questions

N/A yet.

Alternatives

Current state. Removal of zephyr,shell-uart support from DTS does not seem to be good option.

@de-nordic de-nordic added the RFC Request For Comments: want input from the community label Aug 19, 2020
@de-nordic de-nordic changed the title Get rid of shell UART device selection in Kconfig RFC: Get rid of shell UART device selection in Kconfig Aug 19, 2020
@pabigot
Copy link
Collaborator

pabigot commented Aug 21, 2020

How would this work if the shell UART is to be on a USB CDC-ACM device, for which there are no devicetree nodes?

@pabigot
Copy link
Collaborator

pabigot commented Aug 22, 2020

The underlying issue was reported in #27597 for CONFIG_UART_CONSOLE_ON_DEV_NAME. This seems a fundamental weakness of /chosen/zephyr,foo, but I don't see how to eliminate it. That the devicetree property merely sets the initial value of the Kconfig symbol is a bit subtle.

@de-nordic
Copy link
Collaborator Author

The issue does not seem to be resolvable currently and does not seem to be important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments: want input from the community
Projects
None yet
Development

No branches or pull requests

6 participants