Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in drivers/modem/hl7800.c #28745

Closed
picsil opened this issue Sep 28, 2020 · 1 comment
Closed

Bug in drivers/modem/hl7800.c #28745

picsil opened this issue Sep 28, 2020 · 1 comment
Assignees
Labels
area: Modem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@picsil
Copy link

picsil commented Sep 28, 2020

Describe the bug
Compilation fails if CONFIG_MODEM_HL7800_FW_UPDATE is defined. On line 4673 the call to fs_open is missing a parameter.

To Reproduce
Enable CONFIG_MODEM_HL7800_FW_UPDATE in prj.conf
Build any project using board pinnacle_100_dvk / HL7800 modem.

Expected behavior
Code compiles with this config option enabled

Impact
Workaround by modifying hl7800.c, but this should be fixed.

Logs and console output
/home/reid/software/p3-2.4.0/zephyr/drivers/modem/hl7800.c: In function 'mdm_hl7800_update_fw':
/home/reid/software/p3-2.4.0/zephyr/drivers/modem/hl7800.c:4673:8: error: too few arguments to function 'fs_open'
4673 | ret = fs_open(&ictx.fw_update_file, file_path);
| ^~~~~~~
In file included from /home/reid/software/p3-2.4.0/zephyr/drivers/modem/hl7800.c:41:
/home/reid/software/p3-2.4.0/zephyr/include/fs/fs.h:225:5: note: declared here
225 | int fs_open(struct fs_file_t *zfp, const char *file_name, fs_mode_t flags);
| ^~~~~~~
[31/189] Building C object zephyr/subsys/net/ip/CMakeFiles/subsys__net__ip.dir/utils.c.obj
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /home/reid/software/p3-2.4.0/P3/build

Environment (please complete the following information):
Linux. Fresh codebase, trying to compile my project after a clean west init ; west update. Zephyr version 2.4.0.

Additional context
To fix, change hl7800.c line 4673 to read:
ret = fs_open(&ictx.fw_update_file, file_path, FS_O_READ);

@picsil picsil added the bug The issue is a bug, or the PR is fixing a bug label Sep 28, 2020
@MaureenHelm MaureenHelm added the priority: medium Medium impact/importance bug label Sep 29, 2020
@rerickson1
Copy link
Member

PR #28766 resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modem bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants