Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Civetweb: create separate directory #28941

Closed
KozhinovAlexander opened this issue Oct 5, 2020 · 3 comments · Fixed by #28323 or #30175
Closed

Civetweb: create separate directory #28941

KozhinovAlexander opened this issue Oct 5, 2020 · 3 comments · Fixed by #28323 or #30175
Assignees
@KozhinovAlexander
Labels
area: civetweb area: Modules Enhancement Changes/Updates/Additions to existing features
Milestone
v2.5.0

Comments

@KozhinovAlexander
Copy link
Collaborator

KozhinovAlexander commented Oct 5, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
CivetWeb using samples have potential to spread over multiple directories (especially after merging of #28323).

Describe the solution you'd like
Put all CivetWeb using samples into one civetweb root directory. Thus allowing http/websocket and many more CivetWeb based samples existing in one root directory (e.g. samples/net/civetweb/http_server, samples/net/civetweb/websocket_server).

Describe alternatives you've considered
none. (Maybe your suggestion?)

Additional context
Should be done incrementally after merging of #28323 and #30175
@KozhinovAlexander KozhinovAlexander self-assigned this Oct 5, 2020
@KozhinovAlexander KozhinovAlexander added this to the v2.5.0 milestone Oct 5, 2020
@KozhinovAlexander KozhinovAlexander linked a pull request Oct 5, 2020 that will close this issue
Civetweb WebSocket Server sample #28323
Merged
@KozhinovAlexander
Copy link
Collaborator Author

@jukkar It was mostly your idea, to put CivetWeb samples into same root directory. Please provide short look at this issue.

@jukkar
Copy link
Member

jukkar commented Oct 6, 2020

Agreed with separate directory. The samples/net/civetweb/ is good place to put the sample apps.

@nashif nashif added area: Modules Enhancement Changes/Updates/Additions to existing features labels Oct 13, 2020
@KozhinovAlexander KozhinovAlexander linked a pull request Nov 21, 2020 that will close this issue
CivetWeb reorganize samples #30175
Merged
@KozhinovAlexander
Copy link
Collaborator Author

Reopened due to #30175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KozhinovAlexander KozhinovAlexander

Labels
area: civetweb area: Modules Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
v2.5.0
3 participants
@nashif @jukkar @KozhinovAlexander