Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uart_nrfx_uart fails uart_async_api_test #29173

Closed
pabigot opened this issue Oct 13, 2020 · 4 comments
Closed

uart_nrfx_uart fails uart_async_api_test #29173

pabigot opened this issue Oct 13, 2020 · 4 comments
Assignees
Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Oct 13, 2020

From #29092:
The remaining failures are shown here:

Test failures for ready events
===================================================================
START - test_chained_write

    Assertion failed at ../src/test_uart_async.c:492: test_chained_write: (k_sem_take(&rx_rdy, K_MSEC(100)) not equal to 0)
RX_RDY timeout
 FAIL - test_chained_write
===================================================================
START - test_long_buffers_setup
 PASS - test_long_buffers_setup
===================================================================
START - test_long_buffers

    Assertion failed at ../src/test_uart_async.c:564: test_long_buffers: (k_sem_take(&rx_rdy, K_MSEC(200)) not equal to 0)
RX_RDY timeout
 FAIL - test_long_buffers
===================================================================
START - test_write_abort_setup
 PASS - test_write_abort_setup
===================================================================
START - test_write_abort

    Assertion failed at ../src/test_uart_async.c:350: test_write_abort: (k_sem_take(&rx_rdy, K_MSEC(100)) not equal to 0)
RX_RDY timeout
 FAIL - test_write_abort
===================================================================
START - test_forever_timeout_setup
 PASS - test_forever_timeout_setup
===================================================================
START - test_forever_timeout

    Assertion failed at ../src/test_uart_async.c:426: test_forever_timeout: (k_sem_take(&rx_rdy, K_MSEC(100)) not equal to 0)
RX_RDY timeout
 FAIL - test_forever_timeout
===================================================================
Test suite uart_async_test failed.
===================================================================
PROJECT EXECUTION FAILED

Serendipitously confirming my belief that the use of k_delayed_work there was wrong, these are fixed by #28891 which changes the driver to use to the new delayable work API.

Originally posted by @pabigot in https://github.com/zephyrproject-rtos/zephyr/issue_comments/706385538

@pabigot pabigot self-assigned this Oct 13, 2020
@pabigot pabigot added the priority: low Low impact/importance bug label Oct 13, 2020
@pabigot pabigot added area: UART Universal Asynchronous Receiver-Transmitter platform: nRF Nordic nRFx labels Oct 13, 2020
@carlescufi carlescufi added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels Oct 13, 2020
@pabigot pabigot removed their assignment Oct 15, 2020
@PerMac
Copy link
Member

PerMac commented Oct 19, 2020

Other tests from ./tests/drivers/uart/ also fail (i.e: all tests from uart_mix_fifo_poll)

@anangl anangl self-assigned this Oct 20, 2020
@anangl
Copy link
Member

anangl commented Oct 20, 2020

@pabigot I cannot reproduce those failures, even if I go back to the commit 4a0a196 that was merged in #29093 that closed #29092. All test cases pass, unless I remove the connection between P1.01 and P1.02. But then obviously even more test cases fail. Am I missing something?

@pabigot
Copy link
Collaborator Author

pabigot commented Oct 20, 2020

It could be dependent on the relative errors in HFCLK and LFCLK.

@nashif nashif added the bug The issue is a bug, or the PR is fixing a bug label Dec 15, 2020
@carlescufi carlescufi assigned pabigot and unassigned anangl Jan 26, 2021
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 26, 2021

Looks like the failures noted above are a result of not shorting P1.01 with P1.02, and I can't reproduce any problems with information available, so consider this fixed by subsequent changes to the test or infrastructure.

@pabigot pabigot closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants