Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all tests of module mcuboot #29397

Closed
nvlsianpu opened this issue Oct 21, 2020 · 4 comments · Fixed by #30285
Closed

Build all tests of module mcuboot #29397

nvlsianpu opened this issue Oct 21, 2020 · 4 comments · Fixed by #30285
Assignees
Labels
area: MCUBoot area: Modules area: Tests Issues related to a particular existing or missing test Enhancement Changes/Updates/Additions to existing features

Comments

@nvlsianpu
Copy link
Collaborator

nvlsianpu commented Oct 21, 2020

only test for frdm_k64f board are build for mcuboot project
I expected that all test for which platform_allow: in https://github.com/zephyrproject-rtos/mcuboot/blob/master/boot/zephyr/sample.yaml of should be tested.
For MCUBoot nrf52840 boards are used as target for integration test (all of them are expected to be build-only)

Neither nrf52840dk_nrf52840 nor nrf52840dongle_nrf52840 are integration platform which cause impossible to use it for mcuboot's integration test.

These a few mcuboot integration tests are testing a few basic configuration build.

@PerMac
Copy link
Member

PerMac commented Nov 26, 2020

With the #29829 merged this should be possible by adding platforms that need to be tested (build level in case of not simulated ones) in integration_platforms list. This list expands/limits the CI to the platforms in the list (platform_allow only works as an additional filter preventing anything that is not on the list from being tested).

@nvlsianpu
Copy link
Collaborator Author

@PerMac Have to check again, but as i remember mcuboot was not build even with these hints. Maybe because it is external application.

@nordic-krch
Copy link
Contributor

Just wanted to mention that was just fixing an issue with mcuboot failing to compile in certain configuration (reported by downstream project) #35765. It is not verified by zephyr CI though.

@nvlsianpu
Copy link
Collaborator Author

nvlsianpu commented Jun 1, 2021

Can building of MCUboot be added to the CI? I think additional twister run with --testcase-root set to bootloader/mcuboot/boot/zephyr will do the job.

@carlescufi Can this be considered and implemented? Maybe this need TSC approval.

Here draft with modified sample.yaml
mcu-tools/mcuboot#890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: MCUBoot area: Modules area: Tests Issues related to a particular existing or missing test Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants