Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC: tests fail on nsim_hs with one register bank #29916

Closed
evgeniy-paltsev opened this issue Nov 10, 2020 · 1 comment · Fixed by #30125
Closed

ARC: tests fail on nsim_hs with one register bank #29916

evgeniy-paltsev opened this issue Nov 10, 2020 · 1 comment · Fixed by #30125
Assignees
Labels
area: ARC ARC Architecture bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@evgeniy-paltsev
Copy link
Collaborator

Describe the bug
If we configure nsim_hs to have one register bank we'll get significant amount of tests failed.

To Reproduce
Steps to reproduce the behavior:

Apply this patch (I've tested it on top of b2bd0a0 commit):

diff --git a/boards/arc/nsim/support/nsim_hs.props b/boards/arc/nsim/support/nsim_hs.props
index 59a4f6a9c5..b79d4a3de1 100644
--- a/boards/arc/nsim/support/nsim_hs.props
+++ b/boards/arc/nsim/support/nsim_hs.props
@@ -1,8 +1,7 @@
        nsim_isa_family=av2hs
        nsim_isa_core=2
        arcver=0x52
-       nsim_isa_rgf_num_banks=2
-       nsim_isa_rgf_banked_regs=32
+       nsim_isa_rgf_num_banks=1
        nsim_isa_rgf_num_regs=32
        nsim_isa_rgf_num_wr_ports=2
        nsim_isa_big_endian=0
diff --git a/soc/arc/snps_nsim/Kconfig.defconfig.hs b/soc/arc/snps_nsim/Kconfig.defconfig.hs
index a1fd90572f..f46ee92cb9 100644
--- a/soc/arc/snps_nsim/Kconfig.defconfig.hs
+++ b/soc/arc/snps_nsim/Kconfig.defconfig.hs
@@ -13,7 +13,7 @@ config NUM_IRQS
        default 30
 
 config RGF_NUM_BANKS
-       default 2
+       default 1
 
 config SYS_CLOCK_HW_CYCLES_PER_SEC
        default 5000000

Run sanitycheck:

./scripts/sanitycheck --platform nsim_hs

Expected behavior
0 test fail.

Logs and console output

sanitycheck results:

INFO    - Total complete:  240/ 240  100%  skipped:   70, failed:   53
INFO    - 117 of 170 tests passed (68.82%), 53 failed, 794 skipped with 0 warnings in 2310.51 seconds
INFO    - In total 1058 test cases were executed on 1 out of total 302 platforms (0.33%)
INFO    - 153 tests executed on platforms, 17 tests were only built.

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: Zephyr SDK 0.11.4
  • Commit SHA: b2bd0a0 with patch applied
@evgeniy-paltsev evgeniy-paltsev added bug The issue is a bug, or the PR is fixing a bug area: ARC ARC Architecture labels Nov 10, 2020
@evgeniy-paltsev
Copy link
Collaborator Author

Hi @IRISZZW,
as you've fixed similar #26688 could you please also look at this one?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARC ARC Architecture bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
3 participants