Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf pwm broken #30638

Closed
pabigot opened this issue Dec 11, 2020 · 0 comments · Fixed by #30640
Closed

nrf pwm broken #30638

pabigot opened this issue Dec 11, 2020 · 0 comments · Fixed by #30640
Assignees
@pabigot
Labels
area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: high High impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Dec 11, 2020

@galak pwm_nrfx.c doesn't build anymore; adding #define DT_DRV_COMPAT nordic_nrf_pwm at the top seems to work.

Also, doesn't it need to use DEVICE_DT_DEFINE(PWM(idx)) instead of DEVICE_DT_INST_DEFINE(idx) since the instance numbers don't necessarily match the pwmN labels, and the rest of the macros in that file depend on the labels? I'm unfamiliar with what's been going on with DT so I may be mistaken.

Originally posted by @jimparis in #30570 (comment)

Confirmed in nightly builds.
@pabigot pabigot self-assigned this Dec 11, 2020
@pabigot pabigot mentioned this issue Dec 11, 2020
Merged
@galak galak added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: PWM Pulse Width Modulation platform: nRF Nordic nRFx labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabigot pabigot

Labels
area: PWM Pulse Width Modulation bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: pwm: fix nrfx pwm device definition pabigot/zephyr
2 participants
@pabigot @galak