Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puncover worst-case stack analysis does not work #30679

Closed
pabigot opened this issue Dec 13, 2020 · 5 comments
Closed

puncover worst-case stack analysis does not work #30679

pabigot opened this issue Dec 13, 2020 · 5 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Dec 13, 2020

sdk-0.12.0-beta-3 breaks puncover support for worst-case stack analysis from https://docs.zephyrproject.org/latest/guides/optimizations/tools.html#build-target-puncover. No stack data is visible in the puncover web; dropping back to sdk-0.11.4 it shows up.

Not clear whether the problem needs to be fixed here, in the sdk, or in HBehrens/puncover

@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Dec 13, 2020
@nashif
Copy link
Member

nashif commented Dec 13, 2020

just verified the generated .su files are the same across gcc versions.. so this is not the problem.

@galak
Copy link
Collaborator

galak commented Dec 14, 2020

just verified the generated .su files are the same across gcc versions.. so this is not the problem.

I take that to mean its probably on the puncover side.

@nashif nashif added the priority: low Low impact/importance bug label Dec 15, 2020
@nashif nashif self-assigned this Dec 15, 2020
@nashif nashif changed the title puncover does not work with sdk-0.12.0-beta3 puncover worst-case stack analysis does not work Jan 30, 2021
@nashif
Copy link
Member

nashif commented Jan 30, 2021

I am not getting worst-case stack analysis with older SDK and with older Zephyr tree, my suspicion is that some dependency in the modules started breaking this, so it is not a bug in zephyr, need to open a bug in puncover issues. The basic functionality of puncover is still there and works fine.

@nashif nashif closed this as completed Jan 30, 2021
@larson-whisper
Copy link
Contributor

To ease the search for others, there is a PR open on puncover to fix the issue. Applying the fix locally restored stack analysis for us.

https://github.com/HBehrens/puncover/pull/43/files

@yashi
Copy link
Collaborator

yashi commented Dec 26, 2021

The development of puncover seems to be halted. (Three commits in 2020 are the last. Before that is 2017) Is it possible to host it under Zephyr project? Or integrate it with Zephyr SDK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants