Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :216800] Operands don't affect result in lib/os/heap.c #31648

Closed
zephyrbot opened this issue Jan 26, 2021 · 1 comment
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/lib/os/heap.c#L377

Category: Integer handling issues
Function: sys_heap_init
Component: Other
CID: 216800

Details:

371         }
372     }
373    
374     void sys_heap_init(struct sys_heap *heap, void *mem, size_t bytes)
375     {
376         /* Must fit in a 31 bit count of HUNK_UNIT */
>>>     CID 216800:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
>>>     "bytes / 8U <= 2147483647U" is always true regardless of the values of its operands. This occurs as the logical operand of "!".
377         __ASSERT(bytes / CHUNK_UNIT <= 0x7fffffffU, "heap size is too big");
378    
379         /* Reserve the final marker chunk's header */
380         __ASSERT(bytes > heap_footer_bytes(bytes), "heap size is too small");
381         bytes -= heap_footer_bytes(bytes);
382    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Jan 26, 2021
@pabigot
Copy link
Collaborator

pabigot commented Feb 2, 2021

2021-02-02 20:26:49 (change by @pabigot)
Classification: Unclassified → False Positive
Comment:
This is gonna happen when size_t is 32 bits.

@pabigot pabigot closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants