Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :216783] Side effect in assertion in tests/lib/p4workq/src/main.c #31670

Closed
zephyrbot opened this issue Jan 26, 2021 · 1 comment
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/tests/lib/p4workq/src/main.c#L237

Category: Incorrect expression
Function: test_resubmit
Component: Tests
CID: 216783

Details:

231         run_count = 0;
232         simple_item = (struct k_p4wq_work){};
233         simple_item.handler = resubmit_handler;
234         k_p4wq_submit(&wq, &simple_item);
235    
236         k_msleep(100);
>>>     CID 216783:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "run_count" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
237         zassert_equal(run_count, 2, "Wrong run count: %d\n", run_count);
238     }
239    
240     void simple_handler(struct k_p4wq_work *work)
241     {
242         zassert_equal(work, &simple_item, "bad work item pointer");

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Jan 26, 2021
@nashif nashif assigned andyross and unassigned nashif Jan 26, 2021
@nashif
Copy link
Member

nashif commented Jan 27, 2021

false positive

@nashif nashif closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants