Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :216790] Division or modulo by zero in tests/drivers/can/timing/src/main.c #31675

Closed
zephyrbot opened this issue Jan 26, 2021 · 1 comment · Fixed by #32183
Closed
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/tests/drivers/can/timing/src/main.c#L123

Category: Integer handling issues
Function: test_verify_algo
Component: Tests
CID: 216790

Details:

117             }
118    
119             zassert_true(ret >= 0, "Unknown error %d", ret);
120             /* For the given values, we expect a sp error < 10% */
121             zassert_true(ret < 100, "Huge sample point error %d", ret);
122             verify_sp(&timing, samples[i].sp, ret);
>>>     CID 216790:  Integer handling issues  (DIVIDE_BY_ZERO)
>>>     In function call "verify_bitrate", division by expression "timing.prescaler" which may be zero has undefined behavior.
123             verify_bitrate(&timing, samples[i].bitrate);
124         }
125     }
126    
127     void test_main(void)
128     {

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Jan 26, 2021
@nashif
Copy link
Member

nashif commented Feb 9, 2021

@alexanderwachter can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants