[Coverity CID :216791] Side effect in assertion in tests/lib/p4workq/src/main.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/tests/lib/p4workq/src/main.c#L243

Category: Incorrect expression
Function: simple_handler
Component: Tests
CID: 216791

Details:

237         zassert_equal(run_count, 2, "Wrong run count: %d\n", run_count);
238     }
239    
240     void simple_handler(struct k_p4wq_work *work)
241     {
242         zassert_equal(work, &simple_item, "bad work item pointer");
>>>     CID 216791:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "has_run" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
243         zassert_false(has_run, "ran twice");
244         has_run = true;
245     }
246    
247     /* Simple test that submited items run, and at the correct priority */
248     static void test_p4wq_simple(void)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[nashif]

false positive