[Coverity CID :216794] Pointless string comparison in tests/lib/devicetree/api/src/main.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/f91e9fba51e5da46ee5c6822f8656713d74a6ecf/tests/lib/devicetree/api/src/main.c#L1543

Category: Incorrect expression
Function: test_path
Component: Tests
CID: 216794

Details:

1538         }
1539     }
1540    
1541     static void test_path(void)
1542     {
1543         zassert_true(!strcmp(DT_NODE_PATH(DT_ROOT), "/"), "");
>>>     CID 216794:    (CONSTANT_EXPRESSION_RESULT)
>>>     "strcmp("/test/gpio@deadbeef", "/test/gpio@deadbeef")" is always 0 because ""/test/gpio@deadbeef"" is compared against itself.
1544         zassert_true(!strcmp(DT_NODE_PATH(TEST_DEADBEEF),
1545                      "/test/gpio@deadbeef"), "");
1546     }
1547    
1548     static void test_same_node(void)
1549     {
1537             zassert_true(ORD_IN_ARRAY(inst_supports[i], children_ords), "");
1538         }
1539     }
1540    
1541     static void test_path(void)
1542     {
>>>     CID 216794:    (CONSTANT_EXPRESSION_RESULT)
>>>     "strcmp("/", "/")" is always 0 because ""/"" is compared against itself.
1543         zassert_true(!strcmp(DT_NODE_PATH(DT_ROOT), "/"), "");
1544         zassert_true(!strcmp(DT_NODE_PATH(TEST_DEADBEEF),
1545                      "/test/gpio@deadbeef"), "");
1546     }
1547    
1548     static void test_same_node(void)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[mbolivar-nordic]

Closed FP