Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need 2.5 release notes on switch to k_heap from mem_pool #31797

Closed
pabigot opened this issue Jan 29, 2021 · 2 comments
Closed

need 2.5 release notes on switch to k_heap from mem_pool #31797

pabigot opened this issue Jan 29, 2021 · 2 comments
Labels
bug The issue is a bug, or the PR is fixing a bug
Milestone

Comments

@pabigot
Copy link
Collaborator

pabigot commented Jan 29, 2021

First, IMO the release notes should mention that these APIs are now officially deprecated, and repeat the text from the 2.4 release notes saying that they're going away in 2.6.

Second, as described in #31524 (comment), the replacement of using k_heap has a behavior difference that can result in applications that formerly allocated from mem_pools running out of memory with the replacement heap data structure. I don't think that's avoidable, but it too should be mentioned in the release notes as it's likely something other than littlefs broke as a result.

I'm tagging this as a bug because it's a behavior change that can break existing applications that isn't documented, but if it should be something else please recategorize it.

@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Jan 29, 2021
@pabigot pabigot added this to the v2.5.0 milestone Jan 29, 2021
@pabigot
Copy link
Collaborator Author

pabigot commented Jan 29, 2021

@nashif @andyross FYI

@nashif
Copy link
Member

nashif commented Feb 1, 2021

are we going to start filing bugs against release notes that are WIP and part of the release process? Most of the sections of document are still empty and now is the time to start filling those, if the kernel section is not ready by rc3, file a bug please or reopen this.

@nashif nashif closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

2 participants