Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Remove synchronous web3.js calls #205

Closed
frangio opened this issue Jul 5, 2018 · 4 comments
Closed

Remove synchronous web3.js calls #205

frangio opened this issue Jul 5, 2018 · 4 comments
Assignees
Labels
dev:good first issue Beginners welcome! kind:chore Housekeeping tasks
Milestone

Comments

@frangio
Copy link
Contributor

frangio commented Jul 5, 2018

We found one usage of web3.js without a callback, which results in a blocking call.

return web3.eth.getStorageAt(this.address, position)

We want to use asynchronous calls everywhere, otherwise for example we won't be able to implement #172. We should find all instances where web3.js is being used synchronously and add a callback, or consider using a promisified version of web3.js (buidler's?).

@frangio frangio added dev:good first issue Beginners welcome! kind:chore Housekeeping tasks labels Jul 5, 2018
@s1na
Copy link
Contributor

s1na commented Jul 6, 2018

I'd like to give this a try, if it's okay with you guys.

@facuspagnuolo
Copy link
Contributor

For sure @s1na, thanks!

@facuspagnuolo facuspagnuolo added this to the v2.0.0 milestone Jul 10, 2018
@spalladino
Copy link
Contributor

Hey @s1na! Please keep us posted on how it's going with this issue, and if you need any help. Thanks!

@s1na
Copy link
Contributor

s1na commented Jul 12, 2018

@spalladino Hi! Sry it's been some time, I was struggling with #206 and didn't make much progress on this. Please let me know if this is high priority so that either I can spend more time on it, or let someone else work on it instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev:good first issue Beginners welcome! kind:chore Housekeeping tasks
Projects
None yet
Development

No branches or pull requests

4 participants