Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review what we exclude from iOS builds #1984

Open
bernardnormier opened this issue Mar 25, 2024 · 1 comment · May be fixed by #3419
Open

Review what we exclude from iOS builds #1984

bernardnormier opened this issue Mar 25, 2024 · 1 comment · May be fixed by #3419
Assignees
@pepone
Labels
build-system cleanup cpp swift
Milestone
3.8.0

Comments

@bernardnormier
Copy link
Member

bernardnormier commented Mar 25, 2024 •
edited
Loading

We currently exclude all Tcp* from iOS builds of Ice C++ (direct build ands builds for Ice Swift via the Rakefile).

It's surprising that we don't exclude more. For example, we should definitely exclude Service.cpp, and CtrCHandler.cpp. It's likely we should exclude much more, like the ConsoleUtil code.

Note that none of this code is "ifdefed out" for iOS, meaning that we currently include it in the iOS builds even though it's meaningless.
@bernardnormier bernardnormier added this to the 3.8.0 milestone Mar 25, 2024
@pepone
Copy link
Member

pepone commented Mar 25, 2024 •
edited
Loading

like the ConsoleUtil code

ConsoleUtil is used by Instance, Logger, and Timer implementations, for non Windows platforms it just defines consoleErr, and consoleOut as references to cout, and cerr respectively.

@bernardnormier bernardnormier self-assigned this Dec 6, 2024
@bernardnormier bernardnormier removed their assignment Jan 14, 2025
@pepone pepone self-assigned this Jan 22, 2025
pepone added a commit to pepone/ice that referenced this issue Jan 24, 2025
@pepone
Review iOS build excludes - fix zeroc-ice#1984
46b5d92
@pepone pepone linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepone pepone

Labels
build-system cleanup cpp swift
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

Review iOS build excludes pepone/ice
2 participants
@pepone @bernardnormier