Visual cursor jumps to end of completion while real position stays put

[jimeh]

Ever since commit dfa803e I'm afraid I've had issues with the cursor position.

Physically, the position does not change, and any cursor movement/editing actions briefly show the cursor in the correct position again, until a copilot suggestion appears. However it only happens for single-line suggestions from copilot. If it's suggesting multiple lines, the visual cursor position stays in the right place.

Here's a couple of gifs:

On commit 56b7d1b (latest):

On commit 3dcf2a7 with copilot-overlay-safe set to nil:

[zerolfx]

The cursor property of the completion text does not work in your case.

The overlay thing is super easy to conflict with other plugins. I gave up the old approach (copilot-overlay-safe = nil) because of its compatibility.

Now the newer method seems not a perfect solution. Can you try to reproduce it with a minimal setup? So I can try to fix the compatibility issue. If I fail to fix it, I will provide an option to for these two approaches.

[jimeh]

Sure thing, I'll narrow it down to a minimal setup this weekend :)

[jimeh]

That didn't take long to find. First thing I tried was disabling whitespace-mode, and that was culprit.

[zerolfx]

I guess removing newline-mark in your whitespace-style will solve the problem.

[jimeh]

Removing newline-mark did indeed solve the issue for me.

Not sure if you'd consider that a solution or a workaround though, so I'll let you choose if you want to close this issue or not.

Thanks again for your help, and continued support for copilot.el :)

[zerolfx]

I decided to leave it unsolved for now. Figuring out the logic behind overlay and cursor is a pain for me.

The overlay part now is essentially the same as https://github.com/auto-complete/auto-complete/blob/master/auto-complete.el#L927, and I assume it is good enough for general use cases.

[asmeurer]

I'm also having this issue, particularly when the completion involves a newline. I am not using whitespace-mode, and in fact I can reproduce it with a minimal configuration only enabling copilot-mode in emacs -Q.

Here's a minimal reproducer:

;; test.el
(package-initialize)

;; straight.el initialization
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 6))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(add-to-list 'package-archives
             '("melpa" . "https://melpa.org/packages/"))

;; Location of my use-package git clone
(add-to-list 'load-path "~/Documents/use-package")
(require 'use-package)

(use-package copilot
  :straight (:host github :repo "zerolfx/copilot.el" :files ("dist" "*.el"))
  :ensure t)

(add-hook 'prog-mode-hook 'copilot-mode)

Then running:

emacs -Q -l test.el test.py

and typing

def test():

The completion looks like:

Note that it shows the cursor at the end of the completion but it isn't really there. If I start typing more stuff the cursor is still at the : in the def test(): line. Needless to say, I find this behavior to be very disorienting.

[JiaweiChenC]

I also found the issue is still there with whitespace-mode disabled, does anyone have a temp solution for that?