[Content] Set number value to 0 if the api originally returned the value as null #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnar-bin
added
bug
geodem127
approved these changes
Jan 28, 2025
shrunyan
requested changes
Jan 28, 2025
There was a problem hiding this comment.
@finnar-bin this doesn't feel like the correct solution to me. The issue isn't the value being returned by the API. It is how the UI is treating a default 0 value in a required context.
|
Now that I see @geodem127 PR #3176 I'm not sure what the purpose of this PR change would be. @geodem127 PR seems to have the intent of addressing the issue as described in the ticket. |
|
Closing this for now as I feel like a better fix can be made to address the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that users are able to save a content item when a number field originally has a null value
Fixes #3154