Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgRemoveForeignCoin: rename Name field into ZRC20Address #1650

Closed
lumtis opened this issue Jan 27, 2024 · 3 comments · Fixed by #2484
Closed

MsgRemoveForeignCoin: rename Name field into ZRC20Address #1650

lumtis opened this issue Jan 27, 2024 · 3 comments · Fixed by #2484
Assignees
@mohitsethia
Labels
good first issue Good for newcomers m:fungible

Comments

@lumtis
Copy link
Member

lumtis commented Jan 27, 2024

MsgRemoveForeignCoin is used to remove a foreign coin (object tracking ZRC20s)

The message contains a field "Name" that represents the index. The actual index is the address of the ZRC20

Name field should therefore be renamed into ZRC20Address
@lumtis lumtis added good first issue Good for newcomers m:fungible labels Jan 27, 2024
@ptdatta
Copy link

ptdatta commented Feb 6, 2024

Hey @lumtis Can I give it a try?

@lumtis
Copy link
Member Author

lumtis commented Feb 6, 2024

Sure! Thanks for the interest

@ptdatta ptdatta mentioned this issue Feb 6, 2024
Closed
10 tasks
@mohitsethia
Copy link
Contributor

Hi @lumtis , can I contribute to this?

@mohitsethia mohitsethia mentioned this issue Jul 15, 2024
Merged
5 tasks
@coderabbitai coderabbitai bot mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohitsethia mohitsethia

Labels
good first issue Good for newcomers m:fungible
Projects
None yet
Milestone
No milestone
3 participants
@lumtis @mohitsethia @ptdatta