Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Set/GetZetaConnectorAddress, Set/GetERC20CustodyAddress for Bitcoin and Solana signers #2532

Closed
ws4charlie opened this issue Jul 22, 2024 · 0 comments · Fixed by #3332
Closed

Remove Set/GetZetaConnectorAddress, Set/GetERC20CustodyAddress for Bitcoin and Solana signers #2532

ws4charlie opened this issue Jul 22, 2024 · 0 comments · Fixed by #3332
Labels
code-quality Code quality improvement zetaclient Issues related to ZetaClient

Comments

@ws4charlie
Copy link
Contributor

Describe the Issue
Bitcoin and Solana don't have connector and and ERC20 custody contracts. The Set/GetZetaConnectorAddress and Set/GetERC20CustodyAddress methods are to comply with interfaces.ChainSigner interface, so we should considering removing the empty methods from Bitcoin and Solana.

Expected Outcome
A description of what outcome you are seeking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Code quality improvement zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(zetaclient)!: orchestrator V2 zeta-chain/node
1 participant
@ws4charlie