New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZRC20 lock/unlock should not depend on ZRC20 being passed as parameter #3026

Closed

fbac opened this issue Oct 21, 2024 · 0 comments · Fixed by #3068

Assignees

Labels

Contributor

fbac commented Oct 21, 2024

Describe the Issue
Current implementation expects the ZRC20 ABI to be passed as parameter:

func (k Keeper) LockZRC20(
	ctx sdk.Context,
	zrc20ABI *abi.ABI,
	zrc20Address, spender, owner, locker common.Address,
	amount *big.Int,
) error

Expected Outcome
Ideally the API should be capable of getting the ZRC20 on its own. So a caller doesn't have to know anything about ZRC20.

fbac added the m:fungible label

fbac self-assigned this

fbac mentioned this issue

refactor(fungible): ZRC20 Lock/Unlock API should not depend on injected ABI #3068

Merged

5 tasks

fbac closed this as completed in #3068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment