Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Bitcoin outbound code coverage improvement #3445

Open
ws4charlie opened this issue Jan 30, 2025 · 1 comment
Open

test: Bitcoin outbound code coverage improvement #3445

ws4charlie opened this issue Jan 30, 2025 · 1 comment
Assignees
Labels
chain:bitcoin Bitcoin chain related code-quality Code quality improvement zetaclient Issues related to ZetaClient

Comments

@ws4charlie
Copy link
Contributor

ws4charlie commented Jan 30, 2025

Describe the Issue
From what we've seen in the previous Bitcoin refactor PR: #3381, the code relating to Bitcoin outbound and signer are not well covered by unit tests and some of them needs improvement, for example:

  • The TryProcessOutbound is not covered by unit test.
  • The SelectUTXOs has a test flag purely for unit test, we could remove it to be clean.
  • The can be other important methods not covered as well.
  • It is good practice to return an error from TryIncludeOutbound method, even if it's ignored by caller.

Expected Outcome
A description of what outcome you are seeking.

@ws4charlie ws4charlie added chain:bitcoin Bitcoin chain related code-quality Code quality improvement zetaclient Issues related to ZetaClient labels Jan 30, 2025
@ws4charlie ws4charlie self-assigned this Jan 30, 2025
@ws4charlie
Copy link
Contributor Author

@swift1337 TryIncludeOutbound is mentioned above for your comment #3381 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chain:bitcoin Bitcoin chain related code-quality Code quality improvement zetaclient Issues related to ZetaClient
Projects
None yet
Development

No branches or pull requests

1 participant