From da794ec7a3f6c0aab04561f1d5e0d248f9a806e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?= Date: Fri, 6 Dec 2024 14:44:24 +0100 Subject: [PATCH] compiler: Remove warning about superfluous compiler-rt libraries. * This warning's wording is actually inaccurate when using the -fno-compiler-rt or -rtlib=none options. * It's not all that helpful; it's already understood that these libraries are part of the compiler, so printing a warning is just noise. In practice, this warning would always happen when building upstream musl, for example. * We don't warn when we satisfy -lunwind using our bundled libunwind either, or various libc libraries using our bundled libc, or when providing libc++, etc. So I really don't think we should be warning here either. --- src/main.zig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main.zig b/src/main.zig index b946447cc680..cf2d37d08603 100644 --- a/src/main.zig +++ b/src/main.zig @@ -3838,10 +3838,7 @@ fn createModule( create_module.opts.link_libunwind = true; continue; }, - .only_compiler_rt => { - warn("ignoring superfluous library '{s}': this dependency is fulfilled instead by compiler-rt which zig unconditionally provides", .{lib_name}); - continue; - }, + .only_compiler_rt => continue, } if (target.isMinGW()) {