From c74989ee2cc8550bfa775261e2fdad4110277510 Mon Sep 17 00:00:00 2001 From: Thomas-HuWei Date: Thu, 11 Jul 2024 18:00:06 +0800 Subject: [PATCH] move enableDynameField to options --- .../seatunnel/milvus/catalog/MilvusCatalog.java | 15 +++++++++------ .../exception/MilvusConnectionErrorCode.java | 2 ++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java b/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java index 7871e903736..70f129bcaac 100644 --- a/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java +++ b/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/catalog/MilvusCatalog.java @@ -212,7 +212,11 @@ private void createIndexInternal(TablePath tablePath, List vectorIn .withMetricType(MetricType.valueOf(index.getMetricType())) .build(); - client.createIndex(createIndexParam); + R response = client.createIndex(createIndexParam); + if (!Objects.equals(response.getStatus(), R.success().getStatus())) { + throw new MilvusConnectorException( + MilvusConnectionErrorCode.CREATE_INDEX_ERROR, response.getMessage()); + } } } @@ -244,13 +248,12 @@ public void createTableInternal(TablePath tablePath, CatalogTable catalogTable) CreateCollectionParam createCollectionParam = builder.build(); R response = this.client.createCollection(createCollectionParam); if (!Objects.equals(response.getStatus(), R.success().getStatus())) { - throw new CatalogException( - String.format("Create collection failed, err=%s", response.getMessage()), - response.getException()); + throw new MilvusConnectorException( + MilvusConnectionErrorCode.CREATE_COLLECTION_ERROR, response.getMessage()); } } catch (Exception e) { - throw new CatalogException( - String.format("Failed creating collection %s", tablePath.getFullName()), e); + throw new MilvusConnectorException( + MilvusConnectionErrorCode.CREATE_COLLECTION_ERROR, e); } } diff --git a/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java b/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java index 88fc1ce7142..3acc3de804c 100644 --- a/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java +++ b/seatunnel-connectors-v2/connector-milvus/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/exception/MilvusConnectionErrorCode.java @@ -33,6 +33,8 @@ public enum MilvusConnectionErrorCode implements SeaTunnelErrorCode { CLOSE_CLIENT_ERROR("MILVUS-11", "Close client error"), DESC_INDEX_ERROR("MILVUS-12", "Desc index error"), CREATE_DATABASE_ERROR("MILVUS-13", "Create database error"), + CREATE_COLLECTION_ERROR("MILVUS-14", "Create collection error"), + CREATE_INDEX_ERROR("MILVUS-15", "Create index error"), ; private final String code;