Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with numpy>=2 #58

Closed
adrinjalali opened this issue Jun 19, 2024 · 4 comments
Closed

incompatible with numpy>=2 #58

adrinjalali opened this issue Jun 19, 2024 · 4 comments

Comments

@adrinjalali
Copy link

With numpy2:

>>> from quantile_forest._quantile_forest_fast import QuantileForest
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adrin/micromamba/envs/numpy2/lib/python3.12/site-packages/quantile_forest/__init__.py", line 26, in <module>
    from ._quantile_forest import ExtraTreesQuantileRegressor, RandomForestQuantileRegressor
  File "/home/adrin/micromamba/envs/numpy2/lib/python3.12/site-packages/quantile_forest/_quantile_forest.py", line 54, in <module>
    from ._quantile_forest_fast import QuantileForest, generate_unsampled_indices
  File "quantile_forest/_quantile_forest_fast.pyx", line 1, in init quantile_forest._quantile_forest_fast
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
@adrinjalali
Copy link
Author

Encountered this while fixing skops's CI

@reidjohnson
Copy link
Member

@adrinjalali Thanks for reporting, will work on a fix!

@adrinjalali
Copy link
Author

Thanks @reidjohnson . Please let me know when you do a release with numpy2.

@reidjohnson
Copy link
Member

@adrinjalali This should now be fixed in the latest release, version 1.3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants