feat: withTracks is now true by default

BREAKING CHANGE: `withTracks` is more commonly true than false, so we are making that the default
zillow · Sep 27, 2019 · a450420 · a450420
1 parent e4e8ff8
commit a450420
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/components/ReactSlider/ReactSlider.jsx b/src/components/ReactSlider/ReactSlider.jsx
@@ -273,7 +273,7 @@ class ReactSlider extends React.Component {
         thumbClassName: 'thumb',
         thumbActiveClassName: 'active',
         trackClassName: 'track',
-        withTracks: false,
+        withTracks: true,
         pearling: false,
         disabled: false,
         snapDragDisabled: false,

diff --git a/src/components/ReactSlider/__tests__/__snapshots__/ReactSlider.test.js.snap b/src/components/ReactSlider/__tests__/__snapshots__/ReactSlider.test.js.snap
@@ -11,6 +11,30 @@ exports[`<ReactSlider> can render 1`] = `
     }
   }
 >
+  <div
+    className="track track-0"
+    index={0}
+    style={
+      Object {
+        "left": 0,
+        "position": "absolute",
+        "right": 0,
+        "willChange": "",
+      }
+    }
+  />
+  <div
+    className="track track-1"
+    index={1}
+    style={
+      Object {
+        "left": 0,
+        "position": "absolute",
+        "right": 0,
+        "willChange": "",
+      }
+    }
+  />
   <div
     aria-valuemax={100}
     aria-valuemin={0}