Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up model api #96

Open
SamTov opened this issue Jun 12, 2023 · 0 comments
Open

Clean up model api #96

SamTov opened this issue Jun 12, 2023 · 0 comments

Comments

@SamTov
Copy link
Member

SamTov commented Jun 12, 2023

I didn't realise through all of the PRs but the internal models classes are very convoluted now and it is hard to make changes as the steps are distributed over many modules. I would like to clean all of this up as currently making model training changes is difficult if it requires changing things like the apply function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant