Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more blocking functions for integer and double types #261

Closed
sonalgoyal opened this issue May 16, 2022 · 3 comments
Closed

more blocking functions for integer and double types #261

sonalgoyal opened this issue May 16, 2022 · 3 comments
Assignees
Milestone

Comments

@sonalgoyal
Copy link
Member

We need to add more blocking functions for Integer and Double types other than the double and exact ones that we have

In all cases, handle 0 and Nan and negative numbers appropriately.
Both

  • number without last digit. eg for integer type 234 and 233 will return 23, double type - 234.5 and 233.5 will return 23
  • range functions. return 0 if num < 10, 1 if 10 < num < 100, 2 if less than 1000 but greater than 100, 3 if less than 10000(this can be odelled as FirstChars/LastChars functions, one base class and one derived class for each range)
  • lessThan 0 function

extra functions for Double type

  • number with one digit after decimal (23.4445 gives 23.44)
  • number with 2 digits after decimal
  • 3 digits after decimal
    (both above to be modeled with one base class like firstchars)
@sonalgoyal sonalgoyal added this to the 0.3.4 milestone May 16, 2022
@sonalgoyal
Copy link
Member Author

please have appropriate junits for each - check the similarity function junits for an idea of how to build these junits.

@navinrathore
Copy link
Contributor

Code changes made. Junits added.

@sonalgoyal
Copy link
Member Author

i dont see the pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants