Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python api changes #322

Closed
sonalgoyal opened this issue Jun 9, 2022 · 3 comments
Closed

python api changes #322

sonalgoyal opened this issue Jun 9, 2022 · 3 comments
Assignees
Milestone

Comments

@sonalgoyal
Copy link
Member

  1. new pipes - snowflake, inmemory, bigquery, csv - default with header
  2. client options is currently expecting an array [--phase","train"...] we need an empty constructor to which we can set phase. Also current constructor which takes in arguments is confusing, people will mistake it for Arguments object. let us rename
  3. right now setData and setOutput have defaulted to one pipe. we will nto be able to do linking with two datatsets. need to do that.
  4. do we really need zingg.init and zingg.execute? init is not doing much, maybe we can call it internally in execute?
  5. location of zingg.py should be in api and not in phases
@navinrathore
Copy link
Contributor

  • Moved api in python/api folder
  • Moved examples in python/examples folder
  • same for scala specific files

@navinrathore
Copy link
Contributor

In case, "module not found" error occurs, following variable could be set.

export PYTHONPATH=/home/navin/workDir/zingg-1/

@sonalgoyal
Copy link
Member Author

let us close this once we have the changed script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants