Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-script source file src/result.rs should not be executable #133

Closed
musicinmybrain opened this issue May 17, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@musicinmybrain
Copy link

Describe the bug

The source file src/result.rs has the executable bit set in its filesystem permissions, but it is not a script.

To Reproduce
Steps to reproduce the behavior:

  1. Examine https://github.com/zip-rs/zip2/blob/v1.3.0/src/result.rs.
  2. Observe that the GitHub UI describes it as an “Executable File,” but that it is a Rust source rather than an interpreted script.

Expected behavior
Non-script sources should not have executable permissions.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
In particular, executable Rust sources can cause problems with Linux distribution packaging because #![…] directives look like shebang lines, and this can confuse automation.

@musicinmybrain musicinmybrain added the bug Something isn't working label May 17, 2024
@Pr0methean
Copy link
Member

Fixed.

@musicinmybrain
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants