-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide the request info in Context for all Storage() callbacks #325
Comments
I'm not sure if we would want something like this, so I will take it up with my colleagues. Meanwhile. you could easily achieve this by creating your own middleware:
|
Closing as this is the alternative solution to #326. Also discussed in discord. |
@muhlemmer There are other situations where the entire request is useful. In my implementation, I'm passing the request through to the storage layer (using Context) for |
Is your feature request related to a problem? Please describe.
Several times I've needed information that is present in the original
http.Request
when implementingop.Storage
APIs or evenClient
APIS.Describe the solution you'd like
Capture the original
http.Request
and request body and put them intocontext.Context
so anyop.Storage
API can get that information if it needs it.Describe alternatives you've considered
Change all of the
op.Storage
APIs to include additional information.The text was updated successfully, but these errors were encountered: