Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing port and skip TLS verfication #399

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Nov 11, 2024

Locally testing TLS enabled zitadel instances using zitadel-go is hard. It only allows secure connections with port 443, however, listening on 443 often requires special OS privileges. Also, it doesn't allow skipping TLS verification, for example if zitadel uses a self-signed certificate.

Two options are added to pkg/zitadel/zitadel.go that resolve these issues:

  • WithPort
  • WithInsecureSkipVerifyTLS

These changes are needed to properly test a TLS enabled helm chart deployment using a self-signed cert zitadel/zitadel-charts#268

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 0.05%. Comparing base (1214ed0) to head (eec761e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/zitadel/zitadel.go 0.00% 14 Missing ⚠️
pkg/client/credentials.go 0.00% 11 Missing ⚠️
pkg/client/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage    0.05%    0.05%   -0.01%     
==========================================
  Files         127      127              
  Lines      105376   105395      +19     
==========================================
  Hits           57       57              
- Misses     105316   105335      +19     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliobischof eliobischof requested a review from livio-a November 11, 2024 12:28
@eliobischof eliobischof merged commit 5d1a05c into main Nov 11, 2024
7 of 8 checks passed
@eliobischof eliobischof deleted the allow-changing-port branch November 11, 2024 15:24
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants