-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add texts after template reset #6237
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #6237 +/- ##
==========================================
- Coverage 49.95% 45.65% -4.30%
==========================================
Files 1232 820 -412
Lines 110330 85821 -24509
==========================================
- Hits 55110 39180 -15930
+ Misses 52556 44818 -7738
+ Partials 2664 1823 -841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the unit tests need to be adjusted to handle the new event handling:
https://github.com/zitadel/zitadel/actions/runs/5713243265/job/15478370546?pr=6237#step:7:287
I fixed the unit test |
🎉 This PR is included in version 2.30.0-eventstore-performance.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
* fix: add texts after template reset * fix unit tests (cherry picked from commit d937ee3)
🎉 This PR is included in version 2.24.0-ignore-me.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.24.0-ignore-me2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.24.0-ignore-me-ffo.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This reverts commit d937ee3.
* Revert "fix: add texts after template reset (#6237)" This reverts commit d937ee3. * fix: reset of custom text template * add custom bulk limits from issue #6766 (comment)
After template resets, new text set events were not emitted anymore.
Definition of Ready