-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api/v2): implement U2F session check #6339
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #6339 +/- ##
==========================================
+ Coverage 49.95% 50.13% +0.18%
==========================================
Files 1232 1238 +6
Lines 110330 111727 +1397
==========================================
+ Hits 55110 56015 +905
- Misses 52556 53001 +445
- Partials 2664 2711 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 5859d78.
such as: - domain (RPID) - user_interacion Rename `passkey` to `web_auth_n` so that it can be reused for U2F. Implementation for the latter is WIP.
This comment was marked as outdated.
This comment was marked as outdated.
🎉 This PR is included in version 2.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This change adds U2F support to the new (v2alpha) Session API. As the WebAuthN mechanism is the same as passkeys, the API is refactored to accommodate both U2F and Passkey use-cases with the same API Request message format.
The requested challenges are now message type, instead of a repeated enum.
RequestChallenges
can be used to obtain aWebAuthN
challenge, with the needed parameters such asdomain
anduser_verification_requirement
.domain
was moved out of theCreateSessionRequest
as it is only needed forWebAuthN
user_verification_requirement
controls if the WebAuthN is a passkey or U2F level verification.Updates #5477
Definition of Ready