Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager gas cost estimates for max ETH deposits #208

Open
r0wdy1 opened this issue Jul 14, 2023 · 1 comment
Open

Eager gas cost estimates for max ETH deposits #208

r0wdy1 opened this issue Jul 14, 2023 · 1 comment
Assignees
@maxaleks
Labels
enhancement New feature or request UI

Comments

@r0wdy1
Copy link
Contributor

r0wdy1 commented Jul 14, 2023

When a user is depositing maximum available ETH via direct deposit there's nothing left to pay for gas, therefore we should eagerly estimate possible cost upper bound.
This can be done by using a prepare hook with a specified unit of gas cost
https://wagmi.sh/core/actions/prepareWriteContract#gasprice-optional
A unit of gas cost should be configured at pool level for native pools
@r0wdy1 r0wdy1 added the UI label Jul 14, 2023
@maxaleks
Copy link
Collaborator

Estimated time: 1 day

@maikReal maikReal added the enhancement New feature or request label Oct 26, 2023
@maikReal maikReal assigned maxaleks and unassigned maikReal Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxaleks maxaleks

Labels
enhancement New feature or request UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxaleks @maikReal @r0wdy1